saltstack/salt — pull request #12176 by terminalmage (2014-04-22 00:36:41+00:00)
Title: Audit error reporting in states, fix traceback in state.template

This pull request normalizes error reporting quite a bit. The ID declaration was referred to both as "Name" and "ID", and "SLS" was both capitalized and uncapitalized.

In addition, this fixes #11359 by identifying short declarations with no arguments which contain a trailing colon, and providing a meaningful error message. See [here](https://github.com/saltstack/salt/issues/11359#issuecomment-40983833) for an example of the error message.

This also catches the same behavior when state.highstate/state.sls are invoked, and provides a similar error message.

Finally, this pull request sets the correct outputter for both state.template and state.template_str. Before, it was displaying output using the default (nested) outputter, when it should have been run through the highstate outputter.

**NOTE: Because this pull request changes error messages, there is likely to be test breakage, which will need to be addressed before this is merged.**