kfran99/Library-of-Kristin — pull request #1 by mercul3s (2014-04-21 07:04:36+00:00)
Title: adding code review comments

You don't need to merge this pull request, just review the notes I've made. I added some comments on methods or logic that seemed unclear, or for cleanup. Additional notes:
* to remove *.pyc files, do a git rm app/*.pyc. Then commit and push, and that should remove them from the library.
* use docstrings (‘’’ this is a doctoring ‘’’) where possible especially for longer comments (multiline especially). If they are added after your function definition then they can be used as documentation if you choose to use the python documentation library (useful to know for future python programming).
* set your salt in the config as an environment variable so that you don’t have to type it multiple places in your controller
Hope that helps and of course let me know if you have questions.