karma-runner/karma — pull request #1040 by pkozlowski-opensource (2014-04-18 17:18:47+00:00)
Title: fix(server): don't wait for socket.io store expiration timeout

This is kind of "question PR" (sorry, myself I hate those types of PRs but still too new to Karma internals to be able to say if this is the best approach or not...).

So, the story is the following one: socket.io has a timeout to clean data in a store, ex:
https://github.com/LearnBoost/socket.io/blob/0.9/lib/stores/memory.js#L137

Unfortunately this timeout prevents Karma's node process from existing properly when the test run is finished. The quickest fix is to default this timeout to 0. While it fixes my immediate problem, I'm not sure what are the consequences to Karma of doing so. I'm not sure if Karma is associating any data with a socket in the way that would make usage of socket.io store - in this case defaulting this timeout to 0 could have some side effect.

So, once again, fishing for feedback here more than expecting it to be merged immediately.