ChrisChinchilla/CiviCRM-eWay-recurring-payment-processor — pull request #7 by kenwest (2014-04-14 23:48:13+00:00)
Title: I wanted to create this as an issue but was unable

Chris, I was hoping to create this as an issue, but was unable. Is it OK to be given that permission? Thx.

This change prevent 3 notices from being generated by unset $params values:

1. 'is_recur' was not being tested before being used
2. the code for setting 'fullAddress' had been omitted when the in-core eWAY processor was copied
3. the setting of 'country' was removed because a) it's not expected by eWAY as part of the request and b) it's not in the 2-letter format eWAY expects (I think CiviCRM supplies 'country' as 3-letter ISO codes).

The issue I wanted to raise is with respect to 3.b. I don't think any current action is needed, but I just want to put it 'out there' so folks knew about it.