rapid7/metasploit-framework — pull request #3235 by todb-r7 (2014-04-10 22:22:41+00:00)
Title: First little bit at Bug 8498

We have lots of datastore modified errors, usually to avoid defaults for HTTP clients. Turns out, you can pass rhost/rport directly to send_request_cgi. However, vhost was not keeping up -- it would default to datastore['RHOST'] if not set.

This fixes that, and also modifies two modules to take advantage of the fix. Also, those modules have slight updates to set a default year of last year.

@wchen-r7, do you see any problems with this? If not, I'll see about rspec'ing it (shouldn't be hard assuming we have existing HTTP client tests)

## Verification

- [ ] `use auxiliary/gather/corpwatch_lookup_name` and set `COMPANY_NAME` to `Google`
- [ ] Run the module and see correct results.
- [ ] `use auxiliary/gather/corpwatch_lookup_name` and set `COMPANY_ID` to `cw_35783`
- [ ] Run the module and see correct results

You can land this if you want, or wait until I hit all the similar modules. I just didn't want to go too far without some eyes on the vhost fix.

IOW, this is a PR in progress... I guess (but it is technically complete for these modules) :)