JorgeFerrer/liferay-portal — pull request #353 by lipusz (2014-04-10 10:20:30+00:00)
Title: [TECHNICAL-SUPPORT] LPS-45811 Missing Action button on Site Membership page

Hey Jorge,

https://issues.liferay.com/browse/LPS-45811
This is the sequel of https://issues.liferay.com/browse/LPS-45544 (JorgeFerrer#349)

I'm wondering if it makes sense to remove that "permissionChecker.isGroupOwner()" checks. I've found that a Group Owner implicitly has those permissions (ASSIGN_MEMBERS, ASSIGN_USER_ROLES etc.)

Or (as a 2nd option) shouldn't we update the GroupPermissionImpl#contains to explicitly check "isGroupOwner" and return if it is? Sorry, if I'm asking stupid questions, but the permission framework and the (eventually non-trivial) hierarchy of permissions can be confusing (at least for me:) sometimes.

If you think it would have any performance drawbacks or whatever concerns you may found, please, just delete this commit before forwarding.

Thanks,

@akosthurzo
Tibor