PrestaShop/PrestaShop — pull request #1653 by bellini13 (2014-04-09 17:33:31+00:00)
Title: Update OrderConfirmationController.php

This change makes more sense to compare the orders module to the modules name. Comparing the orders payment to the modules display name can result in executing the redirect and never hitting the order confirmation page.

For example, if I create a payment module that allows payment via Credit Card.
The module would have the following variables
name="my_great_module"
paymentMethod="Credit Card"
displayName="My Great Payment Module"

Now in the back office module listing, the merchant would see "My Great Payment Module". This makes sense to the merchant who may have many payment modules.
But in the Order History page, the customer would see "Credit Card". This makes much more sense to the customer who has no idea what "My Great Payment Module" is.

But in the order confirmation controller, since "My Great Payment Module" != "Credit Card", then the order confirmation page would never be displayed. Instead you get redirected to the order history page. This is not desirable

Instead we revise the order confirmation controller to compare the orders module name to the actual module name which both are "my_great_module". This gives much greater flexibility