ReadyTalk/avian — pull request #224 by bigfatbrowncat (2014-04-09 12:53:59+00:00)
Title: Properties don't work in some cases

After the properties were refactored, some of our code started to work buggy and crush. Although we couldn't find a simple code that shows the bug (we could test in only in a custom embedded system), we've found 2 obvious bugs that we have solved. After we solved them, everything started to work well.

1. Properties array is made as a local, stack-based array (or a local object on MSVC) that is destroyed after the function returns. But we send this array to a Machine instance and there we don't copy the data, but just take the pointer (that becomes invalid soon). So we made a copying mechanism and everything started to work well.

2. sizeof(CLASSPATH_PROPERTY) returns incorrect value, that leads to an incorect parsing of strings, so we changed it to strlen()

After this changes the stability (with android classpath or without) improved significally.