magit/magit — pull request #1331 by mgalgs (2014-04-09 05:20:39+00:00)
Title: Don't try to run magit-rewrite-diff-pending from magit-status-sections-hook

Ok, turns out the little shim doesn't always show the "help" message. This commit should fix that.

In [9a4e236: "Transition machinery for magit-insert-pending-changes"] an
obsolete function alias and "transition" function were introduced to
help users that may have customized `magit-status-sections-hook` to know
that `magit-rewrite-diff-pending` no longer exists. However, it really
never makes sense to run `magit-rewrite-diff-pending` from
`magit-status-sections-hook` and in some configurations the actual
"help" message is hidden by the error from
magit-rewrite-diff-pending. Fix this unnecessary confusion by *not*
running `magit-rewrite-diff-pending` from the shim function.