DarkstarProject/darkstar — pull request #105 by starlightknight (2014-04-04 03:31:34+00:00)
Title: Start to Implement White Mage Job Ability Afflatus Misery

Started implementing the White Mage Job Ability "Afflatus Misery", which is currently missing.

References:
http://wiki.ffxiclopedia.org/wiki/Afflatus_Misery
http://wiki.bluegartr.com/bg/Afflatus_Misery

What's Done:
-The ability can activate and grant the effect EFFECT_AFFLATUS_MISERY
-Afflatus Misery / Afflatus Solace will overwrite each other
-Added tracking MOD_AFFLATUS_MISERY to battleutils to keep the last damage count, used to calculate bonuses
-Updated Esuna script to grant the Afflatus Misery bonus if its active; if its active it will heal 2 effects instead of one, and can remove effects normally only removable by Erase as well.
-Updated Banish Spells to get the potency bonus if casted while Afflatus Misery is active, using the Gartr info as a guide. I could not find any exact formula, so I made it as close to the info from FFXIclopedia/Gartr as possible. This applies to Banish spells only (NOT holy, as holy is boosted by Afflatus Solace)

Todo List:
-Cura bonuses - I will work on this next commit.
-Auspice Bonus - this one I could use a little advice on for further development.

The requirements say two main things:

1) That you will receive the affect of Enlight while both Misery & Auspice are active. Is the appropriate place to enforce this behavior with OnEffectGain / OnEffectLoss in the two effect scripts?

2) Each time the WHM misses while meleeing when Misery & Auspice are both active, the WHM receives +10 accuracy. But the bonus only lasts while the combination of Auspice & Misery lasts. I'm assuming I would have to manage bumping the modifier for the accuracy bonus modifier up in a function in battleutils each time the player misses, Would I then grant accuracy boost effect to the player and then cancel it in OnEffectLoss if either Auspice or Afflatus Misery wears off?

If someone could point me in the right direction as to how it would be considered proper to do this that would be appreciated and I would be glad to work on this further..

-SLK