Komet/MediaElch — pull request #354 by ArgelErx (2014-04-04 06:43:02+00:00)
Title: Needless call of MovieSearchWidget::showResults.

*Problem*
Scrapers are Singeltons. MovieSearch and MakeMkvDialog are also Singeltons. MovieSearchWidget has two instances (MovieSearch and MakeMkvDialog) that are both connected to the same scraper signal (searchDone).

*Effect*
MovieSearchWidget::showResults is called for each instance of MovieSearchWidget. See debug output of commit bc8f6472e8c3cc46ab2b5e3c49b3e6ffd8b414a a for demonstration with MovieSearch and TMDB scraper.

*Possible fix*
MovieSearchWidget creates its own scraper instances. See commit f62667d6131666c682bd4dfc9bbca8bad6a0e5dd.

*Problem with Fix I*
Stray scraper settings widget combobox.

*Reason*
MovieSearch is a Singleton. MainWindow instance is not yet initialized at MovieSearch instanciation time.

*Possible fix*
No MovieSearch Singelton. See commit e08feb4fc7135cbbbde190699daf2927df9372e5.