opennewzealand/twfynz — pull request #1 by tuttinator (2014-04-02 08:44:09+00:00)
Title: Refactor specs

Note: This pull request is not complete.

This repository still needs an enormous number of hours of work done on it. Like, think of a really really high number and probably double it. Totes.

Before this PR the number of failing tests was over 900, with deprecation warnings preventing people from being able to follow the test output.

Failing tests have been reduced to 432 and deprecation warnings all removed.

There is one architectural change, which is to use the Postgresql through the pg gem. Postgres is kind of the new standard, and the SQL datastore of choice for Heroku - which could be a staging server environment for quickly testing it doesn't explode.

The database.yml has been added to .gitignore - a kind of best-practice to let developers write their own machine-specific config, especially.

I still think a (parallel) re-write is not a bad idea because there are quite a few fairly fundamental real architectural issues; but there is deep esoteric domain knowledge about the mechanics of parliamentary process, debates and other fascinating archaic wisdom buried in this repository. It's like an adventure.