paulruvolo/SoftwareDesign — pull request #14 by abekim (2014-04-03 07:01:16+00:00)
Title: Graded/hw6

Functionality | Documentation | Design | Total
--- | --- | --- | ---
4.5 | 5 | 4.5 | 4.6

Hey @cwallac & @rvanderheyde,

You guys did an awesome job in general at getting a game together and did it in a super simple way without convoluted extensions or libraries. Kudos to you for that. However, there was something lacking on the functinoality side of things, which was hard to overlook; having said that, I may have misunderstood what the game is meant to be.

#### Ghost Blocks

Ghost blocks on both the main block (`Jumper`) and the platforms (`Platform`).

- The block bounces back even when I have it bouncing between two blocks on the top tier. I assume the idea was to stay alive by climbing higher and higher, which means weaving through the randomly generated tier of 3 blocks.
- Similarly, if I go fast enough (though harder to control), I can pretty much pass right through the blocks.

Both of these issues might be something directly related to collision detection, which I'd be happy to look at with you :smiley:

#### Clean Yo' Code

I decided to only look at GameTest.py because that was the most well-documented. If you don't need it, make my life easier and delete those files.

#### Other Comments

Use `if...elif...else` statements for `Jumper.jump`, `PyGameKeyboardController.handle_keyboard_event`, and your `__main__` script. This lets Python (in general) run much quicker, makes your code more readable, and helps you avoid duplicates like the one in the main script.

Let me know if you have any questions or need any clarifications! You guys definitely killed it with this game. It's always a pleasure grading your works.

Once you've read the comments (both on the PR and under files changed), make a comment to the pull request or send me/Diana an email, letting us know that you've checked them out. Afterwards, close the PR (and optionally delete the graded branch)

#### REMEMBER NOT TO MERGE THESE PRs!