holatuwol/liferay-portal — pull request #19 by jonathanmccann (2014-04-02 15:01:28+00:00)
Title: LPS-45492

Hey Minhchau,

I wanted to get your thoughts on this pull. There are many different options we could go with, and Preston and I don't know which one would be the best:

1. The one on this pull is taken from the format of LayoutExporter (two different messages based on whether or not the Stopwatch is instantiated)
2. Hugo suggested using a boolean to track whether or not the logging was enabled from the beginning (https://github.com/hhuijser/liferay-portal/pull/1816)
3. We could check to see if the log is enabled and the stopwatch is not null and only have one message (https://github.com/jonathanmccann/liferay-portal/pull/226)
4. Or we could instantiate the stopwatch outside of the "if (log enabled)" so that it is never null

Sorry for all the options!