cfinke/Feed-Sidebar — pull request #86 by Quicksaver (2014-04-01 01:03:47+00:00)
Title: Feed Sidebar styling to make it look more native

Hi Chris,

To be honest, when I sent you the e-mail earlier, I was still using version 8. I saw later that you had already fixed a lot for 8.0.2 (your github repo is still at 8.0.1 by the way), and it looked much better already!

Anyway, here's the changes I mentioned I was working on in my e-mail. Mostly I guided myself by the bookmarks and history sidebars, and tried to make the feeds sidebar resemble them more.

Plus a few "extras":
- Styled the "all" button with the others
- The close-preview button didn't have an icon in linux
- The search-toggle button wasn't checking itself when opening the sidebar if the search-bar was already shown
- The loading-text was covering the borders of the preview box in the windows classic theme when it wasn't shown (not really visible in the screenshot below though)
- The close-preview button was a little off (ugly) in windows

Obviously, there's a little of my personal taste in there. I hope you like it, but if you want me to, I'll change anything you don't like or don't agree with of course.

I put together a few screenshots, so you can see the changes quickly. They are all ordered as Bookmarks Sidebar - Feed Sidebar (8.0.1) - Feed Sidebar (with this patch).

There's just a couple of things that you should know.

[Bug 909820 - New Aero list-item hover styling leaves white line behind](https://bugzilla.mozilla.org/show_bug.cgi?id=909820) - basically, the current places styling (that bookmarks, history, and now feeds use) leaves a little white line when mousing over and out of an item in the sidebar. It's not bothersome (barely noticeable), so they're not giving it a very high priority, but hopefully they'll fix it soon.
[Bug 983819 - Sidebar style looks bad on Windows 8](https://bugzilla.mozilla.org/show_bug.cgi?id=983819) - in short, they might change the sidebar style for Windows 8 some day.

I'm following closely both of those bugs, because they also affect my OmniSidebar. When they do, if something needs to be updated in case it's not fixed automatically in the feeds sidebar, I'll be happy to create a new patch for this. I'm just telling you this mostly to give you a heads up.

Let me know what you think or if you need anything for this.
Luís Miguel

Screenshots
-----------------

Windows XP (classic, the colors are a bit dark because it's following the system's colors, and I usually test on a machine with a bit of a dark theme, but I was too lazy to change it).
![feedscompare-winxp](https://cloud.githubusercontent.com/assets/802086/2574631/4763bc4a-b937-11e3-9d5e-4bf4e8fa519c.JPG)
Windows Vista/7 (aero)
![feedscompare-win7aero](https://cloud.githubusercontent.com/assets/802086/2574634/61690c80-b937-11e3-8555-f899d7d22619.jpg)
Windows 8
![feedscompare-win8](https://cloud.githubusercontent.com/assets/802086/2574635/669613ec-b937-11e3-803b-c5bff3b7d3c1.jpg)
Mac OS X
![feedscompare-mac](https://cloud.githubusercontent.com/assets/802086/2574639/6d23c6b4-b937-11e3-936b-9514b819b915.jpg)
Linux (Ubuntu)
![feedscompare-linux](https://cloud.githubusercontent.com/assets/802086/2574640/74db233e-b937-11e3-8239-323833686706.jpg)