charliegerard/newsreader — pull request #1 by mathildathompson (2014-03-30 09:51:34+00:00)
Title: Revisions

- I know you were disappointed, but I was very happy with your first project;
- You have definitely got to grips with model associations and how to handle data from other sites!
- A couple of things to note, I have put the rss feed code into a method in the model, it is best to keep your logic in the model when possible to keep the controllers thin and easy to read;
- Also when people choose to follow sources, in the follow route, you were getting the rss feed from the source all over again, I was not sure why you were doing this? We are checking that the feed has an rss before we save it to the database;
- Final things that could be done if you can face looking at this project again is a bit more error checking!