citizengit/iwitness — pull request #1 by mathildathompson (2014-03-30 04:34:33+00:00)
Title: Revised changes

- Very impressive 1st project Kriss, you have really nailed Google Maps - I also like the way you are passing local variables through partials and rendering different layouts;
- In a couple of places I have refactored your code by taking the logic out of the controller and putting it in the model, try to keep the controllers as thin as possible;
- Also your views have a lot of conditionals in them try and simplify this;
- The flow that I found difficult to follow was when you post the form to search for posts in a specific location; You have overridden the routes to post into the sessions controller and set the address and distance as session variables - why is this necessary? I think you could post the form directly into the posts controller and still have all of the data that you need. If you do not think this is possible a good idea, lets discuss, I am interested to know your thoughts on this;
- And finally remember to avoid floats where possible!