basho/riak_ensemble — pull request #10 by jtuple (2014-03-28 02:00:50+00:00)
Title: Address numerous issues identified during testing

This pull-request addresses numerous issues identified during testing. This includes bugs with stable leadership, cluster state propagation, ensemble membership/view changes, etc.

This is a massive pull-request with lots of intertwined changes. The goal was to do whatever necessary to make new `riak_tests` pass consistently, without non-deterministic failures.

To simplify review, I've separated this pull-request into logical commits with detailed commit messages. This is a review that is best reviewed commit by commit.

Please look at the various commit messages for additional information about the bugs this pull-request fixes, and how it does so.

This pull-request has sibling pull-requests for `riak_kv`, `riak_core`, and `riak_test`. I'll get those pull-requests out tonight and modify this pull-request with appropriate links.

All testing is currently via `riak_tests` which will be in the soon-to-be-pushed sibling pull-request. However, I have some eunit tests that I might end up pushing to this branch in the near future as well. Including a PULSE based test.

Future pull-request will focus on more documentation as necessary, but given that this is a major rewrite of large portions of `riak_ensemble`, I'd rather get this reviewed/tested and be certain we're not going to have any other significant changes.

This addresses issue #7