xToxikx/MUD — pull request #1 by craigHoe (2014-03-27 18:33:17+00:00)
Title: Updates and suggestions

General C++ suggestions:
* avoid the "using" statement in header files.
* avoid including header files that the current file doesn't need.
* avoid the "system" command as it assumes a platform and there are almost always C++ ways of doing what you want.
* Make constants static so they don't get allocated every time you instantiate an object.
* avoid pragmas as they are not standard and not guaranteed to be implemented by your compiler.

General Design Suggestions:
* You will want to separate your interface from your implementation as much as possible. For example, you are currently just writing info to a console, but eventually you will want to write data to a network socket. This is fine for testing in that you may want to make sure you game works without having to deal with the socket stuff since those two things are separate. You have have login logic, but that logic is tied up with cout and cin statements. Having that logic separate from the interface means that you will be able to eventually reuse it.
* Comments! You code has none. Unfortunately this is very common, but the sooner you get in the habit of clearly documenting your code the better. In the real world you will be reading other peoples code, and other people will be reading your code quite a bit and anything you can do to help communicate your intentions in the code will only make everyone's life easier.