orzubalsky/tradeschool — pull request #145 by dnephin (2014-03-28 05:29:32+00:00)
Title: Some build things I hit while setting up a dev environment

Hello,

I started by getting the project setup and running the tests. The first thing I hit was that I required `setuptools >= 0.7` but I only had `setuptools 0.6`. I worked around this by using a virtualenv and installing the latest setuptools.

Have you considered using virtualenv to manage dependencies? I believe it is taking over as the standard way of creating isolated python environments. I've worked with it quite a bit and I could set it up if you're interested.

Next I ran into a missing dependency (polib), so I added that, and I guess I got a different version of `django-countries` because one of the imports was not working. I fixed the import and pinned the version. Another nice thing about virtualenv is that it actually provides a way to dump all the versions you are using to a `requirements.txt` file (using `pip freeze`) so you can ensure that everyone else is running with the exact same versions during development and deployment.

I moved the development setup steps to a bash script (it uses -x so it still echos everything it is doing to the user), and I automated the step of setting a new secret. Let me know how you feel about this. I like automating everything that is possible. The other change I made was to make the default dev database sqlite3. This makes it a lot easier to automate the dev setup and makes it one less external dependency.

I ran the test suite, but I see these 5 falures: http://pastebin.mozilla.org/4707567

Do you get these in your environment? I looked into the email failures, and from what I can tell the "From" is not being set here: https://github.com/orzubalsky/tradeschool/blob/master/ts/apps/tradeschool/models.py#L266

I see the reply-to header is set, but in 2a96f087 it looks like the from header is not being set anymore. Do the tests just need to be updated to reflect this change?

The other test failure `ES != es` I'm not sure about, but seems minor. I would still like to have a green test suite before I make any changes though.