rails/rails — pull request #14488 by arthurnn (2014-03-26 18:00:30+00:00)
Title: Stop swallowing errors on transaction after callbacks.

### Problem
When raising a standard error on `after_commit` / `after_rollback`, they are logged but swallowed afterwards. IMO, this is dangerous behaviour as people can just ignore the logs and never see those errors.

### Solution
After re-work of the transaction model on rails 4+ this change is a trivial change. We just need to make sure we dont rollback the transaction after its is completed.

### Drawbacks
When people upgrade rails to use the version with this commit(probably 4.2), they will probably start seeing lots of errors on tests, as before they were probably being swallowed, TBH I see this more as a advantage than a drawback.

[fixes #13460]

Would like to get most feedback as possible on this, as this changes rails behaviour.
review @rafaelfranca @tenderlove @dhh @chancancode @senny
cc @vipulnsward @fw42