tgstation/-tg-station — pull request #3132 by fleure (2014-03-22 01:46:14+00:00)
Title: Cleans up security job code

Okay, so here is the deal: There are two definitions of the security job datum, one in our standard jobs directory and the other in Sigyn's "WorkInProgress" directory for departmental access, which we use and is in the .dme compile tree.

Thanks to Byond Magic™, this doesn't cause problems at compile time, but does leave up to question which definition is priority - It seems to prefer Sigyn's overwritten vars, but still uses the remainder definitions in the original security code. So I've just merged the code together in our jobs code directory, preserving the functionality we want.

See this PR as primarily a clean-up job for weird redundant code, but I am *hoping* this will solve this stupid departmental security access we seem to be having on the live server. Maybe the environment SoS compiles in handles .dmes differently, I really haven't a clue. If it's still broken I'll start logging a bunch of vars to disk and pull them after a day or something. Because aside from Byond Magic™ I seriously have no clue what else could be causing problems if it works on a local server.