matthewshafer/tankard — pull request #1 by drpebcak (2014-03-18 03:23:48+00:00)
Title: changing method a bit

I thought this made a bit more sense. Let me know if this ruins something I didn't think of.

Also, here's my rubocop run if you are interested:
I couldn't think of a good way to solve the cyclomatic dependency issues, but it wants you to use more attr_reader!

``````
➜ tankard on style-cleanup! rubocop
Inspecting 29 files
.CCCCCCCCCCCCCC..............

Offences:

lib/tankard/api/beer.rb:124:7: C: Use attr_reader to define trivial reader methods.
def http_client
^^^
lib/tankard/api/beer.rb:128:7: C: Use attr_reader to define trivial reader methods.
def http_request_parameters
^^^
lib/tankard/api/beers.rb:70:7: C: Use attr_reader to define trivial reader methods.
def http_client
^^^
lib/tankard/api/beers.rb:74:7: C: Use attr_reader to define trivial reader methods.
def http_request_parameters
^^^
lib/tankard/api/request/get.rb:4:7: C: Missing top-level module documentation comment.
module Get
^^^^^^
lib/tankard/api/search.rb:110:7: C: Use attr_reader to define trivial reader methods.
def http_client
^^^
lib/tankard/api/search.rb:114:7: C: Use attr_reader to define trivial reader methods.
def http_request_parameters
^^^
lib/tankard/api/search.rb:118:7: C: Cyclomatic complexity for raise_if_required_options_not_set is too high. [8/6]
def raise_if_required_options_not_set
^^^
lib/tankard/api/style.rb:71:7: C: Use attr_reader to define trivial reader methods.
def http_client
^^^
lib/tankard/api/style.rb:75:7: C: Use attr_reader to define trivial reader methods.
def http_request_parameters
^^^
lib/tankard/api/styles.rb:39:7: C: Use attr_reader to define trivial reader methods.
def http_client
^^^
lib/tankard/api/utils/find.rb:6:7: C: Missing top-level module documentation comment.
module Find
^^^^^^
lib/tankard/api/utils/page_finders.rb:6:7: C: Missing top-level module documentation comment.
module PageFinders
^^^^^^
lib/tankard/client.rb:9:3: C: Missing top-level class documentation comment.
class Client
^^^^^
lib/tankard/configuration.rb:2:3: C: Missing top-level module documentation comment.
module Configuration
^^^^^^
lib/tankard/error.rb:2:3: C: Missing top-level module documentation comment.
module Error
^^^^^^
lib/tankard/request.rb:6:3: C: Missing top-level class documentation comment.
class Request
^^^^^
lib/tankard/version.rb:1:1: C: Missing top-level module documentation comment.
module Tankard
^^^^^^
lib/tankard.rb:7:1: C: Missing top-level module documentation comment.
module Tankard
^^^^^^

29 files inspected, 19 offences detected
``````