cms-sw/cmssw — pull request #2877 by wmtan (2014-03-15 01:03:13+00:00)
Title: String returned by value must be stored

This is a fix for a valgrind error discovered by Vincenzo Innocente. The function TypeWithDict::name() returns a string by value. A caller of this function, the free function typeCode(), saved the value of the char* to the embedded C string without saving the string itself, In those cases where TypeWithDict returns a temporary (as it will when the type is a pointer), the stored char* gets used after the temporary string is reclaimed. The fault is in the caller. This pull request has the caller save the returned string on the stack so that it does not get prematurely reclaimed.
This problem predates 7_1_X, but is unlikely to cause a real problem.