elkarte/Elkarte — pull request #1467 by Spuds (2014-03-08 19:35:48+00:00)
Title: Various issues

Mostly around attachments but also fixed a couple of other items

1) help text would not show for config_var 'title' icons. The icon was there, not the text. Broke down the ternary as well, 600 characters is silly
2) wrong var name used when removing an addon generated errors
3) attachment issues.
- moved php error checks to a sub and not in line to improve readability. Also updated it to respond (the same) to max_upload_filesize and MAX_FILE_SIZE
- the function was relying on a post2 being set, but it was not being set that I could see. I also used that to prevent showing the same errors twice if coming from post2 with attachment errors. Not sure that is the final answer there but it better that showing it twice.
- tweaked base jpeg quality to 80 (default is 75 for GD, to aggressive IMO)
- fixed wrong txt value being shown via DD