mono/MonoGame — pull request #2251 by RayBatts (2014-02-27 23:20:37+00:00)
Title: Split SoundEffectInstance/SoundEffect on a per-API basis

The goals for this pull request mirror those found in https://github.com/mono/MonoGame/pull/2243, but for the SoundEffectInstance/SoundEffect classes.

SoundEffectInstance and SoundEffect were split into partial classes, to help separate the code and clarify the growing confusing caused by constant #if/#elseif/#else chains and increase ease of future PRs. This also allows us to pull out common code to the "base" classes so that the behavior of these classes is more uniform.

Note that this pull request is all clean up; There should be no functional changes or new features, but please let me know if any pop up.

While merging these paths together, I did notice a lot bugs and logic errors. I tried to avoid fixing them, as that's a goal for a future PR. It's already confusing enough to view the diff of a restructure like this without changing implementation.