swalters4925/SoftwareDesign — pull request #3 by abekim (2014-02-24 19:13:36+00:00)
Title: Graded Homework 3

**Grade: 4.5/5**

Great work, Sarah! There are some syntactic comments I made that might be useful to keep in mind.

For your levenshtein portion of your homework, if I understand correctly, the function `computeLevenshtein()` returns a list of lists (matrix). In `search_genome_levenshtein` function, you compare the result of `computeLevenshtein()` to a threshold, which to me seems to be a number.

As an experiment, I ran a `list` to `int` comparison and interestingly enough, a `list` is always greater than an `int` or `float`.

I looked this up online and found [this] (http://stackoverflow.com/questions/7167657/python-list-greater-than-number). Apparently in Python, when there's a mismatch in comparison types, it compares them lexicographically, and the word `list` comes after `int` and therefore is greater. It's pretty much computing `"list" > "int"`.

So it seems like your `search_genome_levenshtein` function doesn't fully work, but it's awesome to see you implement it the way you did. :-)

Also, if you're interested in learning a few Python tricks, you should look into Python's list comprehension and ternary notations for readability. I've added stuff on ternary notation on my [Github repo's readme] (https://github.com/abekim) and will continue to update interesting things on there if you want to check it out.

Once you've read the comments (both on the PR and under files changed), make a comment to the pull request or send me/Diana an email, letting us know that you've checked them out. Afterwards, close the PR (and optionally delete the graded branch)

#### REMEMBER NOT TO MERGE THESE PRs!