cms-sw/cmssw — pull request #2569 by wmtan (2014-02-20 22:34:51+00:00)
Title: Properly update empty process history

This is a fix for a bug that has been in place since CMSSW_6_2_0, and another bug that was introduced by the first attempt at fixing this bug.
The original problem was hit by Erik Butz when he tried to read a file written with CMSSW_3_2_5.
For files written in CMSSW_5_0_0 and later, actual FED raw data is recorded as having been created in a process called "LHC" with a module label of "rawDataCollector". If a file written prior to CMSSW_5_0_0 is read in CMSSW_5_0_0 or later, this "LHC" process is added retroactively, which affects the process history. The process history must then be retroactively modified.
This worked fine until CMSSW_6_2_0, when a bug was introduced. There is a map used to map the old process history to the new. In 6_2_0, the entry for an empty old process history was incorrectly omitted from the map. Real raw data prior to CMSSW_5_0_0 had an empty process history. So, the process history ID for real raw data was not found in the map. and a fatal assert fired.
The fix is to simply add the missing entry to the map.
The second problem was introduced a few days ago by an incorrect attempt to fix the above problem.
The second problem caused the failure of two relvals (4.6 and 144.6) and one other test (read312RV).
The fix for the second problem is just to back out the bad fix. That commit is also included in this pull request.