puppetlabs/packaging — pull request #271 by mckern (2014-02-20 22:16:37+00:00)
Title: (maint) Unconditionally popd after pushd regardless of job status

We're encountering a problem where `createrepo` may fail during the
process of generating repo data for platforms. When this happens,
the conditional '&&' is never triggered, so popd is never run.
This leads to a cascade failure due to use of relative paths.

Step one in tracking this down is to remove the conditional '&&'
and unconditionally popd regardless of the exit status of createrepo.