pfsense/pfsense — pull request #951 by stilez (2014-02-20 01:53:22+00:00)
Title: Tighten is_numeric()

Improvements:

1) avoids 'expensive' preg_match() and is a more exact test
2) fixes logic whereby an empty string or anything converted to an empty string, is deemed a valid 'numeric' value

(If an empty string can validate as numeric, it's possible that in some cases a number is expected and missing in a string, but not detected, causing malformed rules or subnet bitcounts, and unexpected issues or vulnerabilities)

-- also moved code to a more logical place in the .inc while doing this, not mixed in between IP handling functions