mavlink/qgroundcontrol — pull request #531 by DonLakeFlyer (2014-02-17 21:59:39+00:00)
Title: Final Warnings fixed plus Warnings as Errors turned on

No response on Issue #508 so I've tried to fix it myself by just reading up on the mavlink message it is trying to send. The original code seemed very strange in that both sides of the if seem to basically do the same thing. Whereas the debug log message seems to indicate it may be trying to not send message if not in local frame coordinates. The original if, sort of tested for local frame as well, but was missing one of the local frame types. Changed to code to check for local frame correctly and send or not send appropriately. Also set coordinate_frame from the way point frame which silences the error. All of this compiles, but I can't figure out how to test this with the simulator. So other than clean compile some help with making sure this is correct is appreciated.

These last changes complete my wild journey through cleaning up all warnings. Build is now clean on Mac, Ubuntu and Windows both debug and release. I've turned on warnings as errors for all build flavors to prevent it from degrading from fully clean.