agnwinds/python — pull request #69 by jhmatthews (2014-02-13 18:43:36+00:00)
Title: Fixed bug in which qdisk structure was incorrectly zeroed before photon ...

...generation.

This fixes a silly error in which the heating stored in the qdisk structure was zeroed before it was even used, meaning that the SEDs used for the ionization state was identical if you were using disk illumination mode 2 or mode 0. To fix, I simply move the zeroing line after photon_gen in python.c. I've tested that this fix moves the illuminating SED up to roughly the expected level.

Interestingly in the spectral cycles the SEDs were different because it still had the information from the last ion cycle.

I just looked in python 58 and the same bug appears to be present there. I'm now a little worried that this may have affected @ssim 's 2005 paper, as a number of reprocessing models were used in that study.