tidyui/Piranha — pull request #240 by kcamp (2014-02-10 19:46:48+00:00)
Title: fix issue where logProvider is lazy-loaded but not returned correctly

in the lazy-load of LogProvider under Config.cs, the logProvider is initialized correctly, but not returned on the initial request. this effectively results in a no-op by virtue of the calling convention from Application.cs

// Get the current log provider (returned incorrectly on first call), but assembly != null evaluates true
assembly = Assembly.Load(Config.LogProvider.AssemblyName);
if (assembly != null)
{
// since this is the second call, LogProvider doesn't lazily load, and we're ok.
var type = assembly.GetType(Config.LogProvider.TypeName);
if (type != null)
LogProvider = (Log.ILogProvider)Activator.CreateInstance(type);
else throw new TypeAccessException("LogProvider " + Config.LogProvider.TypeName + " was not found");
}