Metaswitch/sprout — pull request #381 by mike-evans (2014-02-05 08:53:42+00:00)
Title: [Reviewer Matt] Integration of resolver in to Bono and Sprout

Matt

This is the integration changes for the resolver. This should be in good enough shape to pull in to dev now so we can cut the release, but there are a couple of things I need to sort out.

- I've had to pull out the SIPResolver UTs as valgrind is claiming the UTs are leaking - I think this is a false positive (it's complaining about strings declared in the UT code itself when populating the DNS cache, but only for NAPTR entries). A bit of googling suggests this is a common false positive signature from valgrind but I want to do a bit more investigation.
- I haven't managed to get retrying working. My first attempt didn't work and it looks like, because of the way the proxying is structured, it may take more structural change than I would ideally do at this point. I'll continue looking at this, but it shouldn't hold off getting the code out as it isn't a loss of function.

Mike