TrinityCore/TrinityCore — pull request #11567 by Rochet2 (2014-02-04 18:34:34+00:00)
Title: Core: Add security to C++ scripted options.

This change makes sure that the option details in OnGossipSelect hook are from an option sent by the creature you are at.

Before this only the database coded gossips have had this check as they work with menu_ids and check the menu_id and existence of the option clicked in the menu. (makes sure you clicked an existing option in the menu sent)
For C++ sent options the menu_id is 0 or similar. Thus it cant be used.

Without this it is possible to "click" an option with hacks that doesn't exist in the menu originally sent to the player in C++ coded menus. (selections)