zzzeek/sqlalchemy — pull request #65 by eblume (2014-02-04 01:13:13+00:00)
Title: SQLite dialect: Support reflection for columns with data affinities

Quick note: included in this PR are two commits that I made while learning the code base. The first is a simple ignore for "*.egg" and the second is a rather sweaping PEP8 formatting change for the sqlite dialect `base.py`. **Please feel free to ask me to remove these.** Some people find things like that trivial and pedantic - no sweat, I can rebase them out of existence and resubmit the PR, no problem.

Otherwise, included is reflection support for SQLite databases that have bizarre column names. This is a feature of SQLite, and without it reflection is broken for some valid SQLite databases.

I had to add an @skip('sqlite') to one of the generic reflection tests to get all of the tests to pass. This test was a test to ensure that the database emits a warning when reflection failed to determine the type of a column. Because the affinity algorithm will always find a valid data type for a column, no such situation exits any more. Therefore skipping the test for sqlite seemed the right thing to do... let me know if you disagree.

Thanks, and please let me know if I should include anything else or change my approach.