laravel/framework — pull request #3414 by ebollens (2014-01-31 16:55:15+00:00)
Title: Minor Clarity and Type-enforcement Fixes

A few minor tweaks in this PR:

1. Forced `array` type for second parameter of `Illuminate\Cache\Tagset::__construct()`, given that it creates an instance member variable that has array-only functions used over it.
1. Renamed `$encrypter` instance member variable to `$cookies` in in `Illuminate\Cookie\Queue` because `$encrypter` property is never used while undefined `$cookies` property is. Note that, given PHP's implicit member variable rules, visibility was changed from `protected` to `public` per semantic versioning in case someone is actually using this property.
1. Added an instance member variable `$container` to `Illuminate\Database\Capsule\Manager` as it is used implicitly. As with above, `public` visibility to avoid breaking anyone who might have been using this because of its implicit definition.
1. Added enforcement of method argument type in protected method `Illuminate\Database\Connectors\ConnectionFactory->createConnection()` based on strict requirements for this variable as imposed by `\Illuminate\Database\Connection`, which is called from this method without this variable otherwise being changed to match signature.
1. Removed unused method argument in `Illuminate\Database\Query\Builder->orWhereBetween()`, which also aligns it with the argument signature of `Illuminate\Database\Query\Builder->orWhereNotBetween()`.
1. Removed unused local variable in `Illuminate\Database\Query\Grammars\SqlServerGrammar->compileAnsiOffset()`.
1. Removed unused argument of closure used internally within in `Illuminate\Database\Connection->unprepared()`.
1. Added phpdoc to annotate magic method calls available in `Illuminate\Cache\CacheManager` based on `Illuminate\Cache\StoreInterface`, which is the interface implemented by all the cache drivers.
1. Fixed phpdoc to denote null-accepting arguments in `Illuminate\Database\Capsule\Manager`.

Minor fixes, sure, but was just digging around a bit this morning so figured might as well..