rapid7/metasploit-framework — pull request #2933 by wvu-r7 (2014-01-30 21:32:42+00:00)
Title: Fix in_super-reliant msftidy checks

The conversion from hard tabs to two-space soft tabs broke a few checks.

```
wvu@kharak:~/metasploit-framework:master$ tools/msftidy.rb modules | grep ERROR | grep -v datastore
wvu@kharak:~/metasploit-framework:master$ git checkout -q beug/in_super && !!
git checkout -q beug/in_super && tools/msftidy.rb modules/ | grep ERROR | grep -v datastore
modules/auxiliary/admin/cisco/cisco_secure_acs_bypass.rb - [ERROR] '<' is a bad character in module title.
[snip]
wvu@kharak:~/metasploit-framework:beug/in_super$
```

- [ ] Run ```tools/msftidy.rb modules | grep ERROR | grep -v datastore```
- [ ] See no errors
- [ ] Check out the topic branch
- [ ] Run ```msftidy``` again
- [ ] Verify that there are errors

The test above accounts for only ```check_badchars```. You can test ```check_ref_identifiers``` using the following method:

```
wvu@kharak:~/metasploit-framework:master$ tools/msftidy.rb modules/exploits/windows/misc/hp_dataprotector_traversal.rb
wvu@kharak:~/metasploit-framework:master$ git checkout -b dev -t master
Branch dev set up to track local branch master.
Switched to a new branch 'dev'
wvu@kharak:~/metasploit-framework:dev$ git merge --no-ff --no-edit beug/in_super
Merge made by the 'recursive' strategy.
tools/msftidy.rb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
wvu@kharak:~/metasploit-framework:dev$ git merge --no-ff --no-edit 99a7630b0da301b27ac495cb027009a8cd9e2caf
Auto-merging tools/msftidy.rb
Merge made by the 'recursive' strategy.
.travis.yml | 2 ++
modules/auxiliary/scanner/printer/printer_version_info.rb | 2 +-
modules/exploits/windows/misc/hp_dataprotector_traversal.rb | 6 +++++-
modules/payloads/stagers/linux/mipsle/reverse_tcp.rb | 4 ++--
tools/dev/pre-commit-hook.rb | 26 +++++++++++++++++---------
tools/msftidy.rb | 9 ++++++++-
6 files changed, 35 insertions(+), 14 deletions(-)
wvu@kharak:~/metasploit-framework:dev$ tools/msftidy.rb modules/exploits/windows/misc/hp_dataprotector_traversal.rb
modules/exploits/windows/misc/hp_dataprotector_traversal.rb - [WARNING] Invalid CVE format: '2013-zz-6194'
modules/exploits/windows/misc/hp_dataprotector_traversal.rb - [WARNING] Poorly designed argument list in 'fakemeth()'. Try a hash.
wvu@kharak:~/metasploit-framework:dev$
```

- [ ] Run ```tools/msftidy.rb modules/exploits/windows/misc/hp_dataprotector_traversal.rb```
- [ ] See no warnings
- [ ] Check out a clean development branch
- [ ] Merge the topic branch
- [ ] Merge 99a7630b0da301b27ac495cb027009a8cd9e2caf from #2932
- [ ] Run ```msftidy``` again
- [ ] Verify that there is a warning for invalid CVE format