ossec/ossec-hids — pull request #22 by jrossi (2014-01-29 15:39:16+00:00)
Title: Cgzones warnings

This request fixes several warnings from static eclipse analyzer (codan), gcc and clang (-Wall -Wextra) for a standard Linux build and a build with geoip support.

I know the diff is also quite long, but i think each change should be feasible.

Some explanations:

* a new Makefile variable "CGEOIPLIB" is introduced to contain the linker and include options for building geoip support. These are moved from "CGEOIP", which now contains only the define macro "DGEOIP", so the hole code is compiled with the define macro, but only the necessary analysisd stuff is compiled with the linking extensions
* from some functions unnecessary parameters are deleted: "OS_AddNewAgent", "AR_ReadConfig", "Check_Hour", "_OS_FindList", "OS_ReadMSG", "os_write_agent_info", "print_syscheck", "OS_ReadSyslogConf", "OS_ReadDBConf", "OS_WriteXML", "_do_print_attrs_syscheck"
* the "GeoIPLookup" function is renamed through a naming conflict with a type in GeoIP.h
* the "GeoIPLookup" function does not return a locale variable any more, therefore the signature change and the different calling procedure
* the global agent variable "logr" is renamed to "agt" through a naming conflict with the global variable in the remoted scope
* the syscheck config struct is renamed from "config" to "syscheck_config" through a naming conflict with a struct within zlib

Origianl Pull Requst: https://bitbucket.org/jbcheng/ossec-hids/pull-request/40/fixing-warnings/diff