tedjt/leader-crunchbase-api — pull request #1 by ivolo (2014-01-26 23:27:31+00:00)
Title: pulling in crunchbase dependency, updating variable names

Hey - a bit more feedback:

#### Passing in Dependencies

In a few other leader plugins, I pass in dependencies like the `crunchbase` library here. I went back and forth on this, but I think I finally settled on when that's proper and when that's not. If the library has state, then it should be passed in. If it doesn't then that plugin should just require that library itself.

In the case of scraper instance being passed in, that scraper is a phantomjs process running on the computer, and I'd rather reuse that process rather than boot up one per each scraper plugin.

In this case, the CrunchBase API wrapper doesn't have state, so its okay to let the leader plugin require it itself. This is better for the user because they can just use this single plugin and not have to worry about what the CrunchBase API wrapper is.

#### Person Variable Naming

- I changed `employeeCount` to `employees` because thats how we have it in the LinkedIn plugin and we should keep the same piece of information named consistently. Overwrites might become a problem in this case, but the solution is likely something different than renaming the variable.
- I changed `crunchbaseUrl` to `crunchbase: { url: .. }l` because I'd like to keep all service specific items inside their own service objects.