picketbox/picketbox-container — pull request #2 by marschall (2014-01-26 22:33:28+00:00)
Title: SECURITY-786 Improve Memory Performance

We did some profiling of or JBoss AS instance and noticed that audit
logging on JavaEE resources is causing most of our allocations outside
[TLAB] [1] s. This was a bit surprising to use since we don't have audit
logging on. We tracked them down to
`org.jboss.security.javaee.AbstractJavaEEHelper.authorizationAudit`
which unnecessarily does an eager string conversion of every
`org.jboss.security.authorization.Resource`. This could be done lazily
on demand when audit logging is on in `AuditEvent#toString`. Since the
map is already of type `Map` simply removing the
call to `#toString()` fixes this.

* don't do eager string conversion of resources in
`AbstractJavaEEHelper#authorizationAudit`

[1]: http://openjdk.java.net/groups/hotspot/docs/HotSpotGlossary.html#TLAB

Issue: SECURITY-786
https://issues.jboss.org/browse/SECURITY-786