rapid7/metasploit-framework — pull request #2918 by wvu-r7 (2014-01-25 01:44:01+00:00)
Title: Clean up adobe_pdf_embedded_exe (redux)

```
wvu@kharak:~/metasploit-framework:master$ tools/msftidy.rb modules/exploits/windows/fileformat/adobe_pdf_embedded_exe.rb
modules/exploits/windows/fileformat/adobe_pdf_embedded_exe.rb - [WARNING] Poorly designed argument list in 'basic_social_engineering_exploit()'. Try a hash.
wvu@kharak:~/metasploit-framework:master$ git checkout -q beug/hash && !!
git checkout -q beug/hash && tools/msftidy.rb modules/exploits/windows/fileformat/adobe_pdf_embedded_exe.rb
wvu@kharak:~/metasploit-framework:beug/hash$
```

- [ ] Run ```msftidy``` on ```modules/exploits/windows/fileformat/adobe_pdf_embedded_exe.rb```
- [ ] See the "poorly designed argument list" warning
- [ ] Check out the topic branch
- [ ] Run ```msftidy``` again
- [ ] Verify that there are no warnings
- [ ] Make sure the module works as before

One step closer to resolving all ```msftidy``` warnings. Thanks for the simplified fix, @todb-r7.

https://dev.metasploit.com/redmine/issues/8498