mozilla/zamboni — pull request #1663 by ngokevin (2014-01-21 22:12:19+00:00)
Title: don't call app.update_status during version.update_status on mkt (bug 960305)

http://sentry.dmz.phx1.mozilla.com/addons/marketplace-dev/group/17692/

It's fixed where we caught this traceback, but this may be worth doing in case this recursion happens in other places.

**Trace:**

- app.update(status=amo.STATUS_PENDING)
- The status update triggers Webapp.watch_status which calls update to update the version’s nomination.
- The nomination update triggers Version.update_status which updates app status by calling Webapp.update_status.
- Webapp.update_status calls app.update(status=amo.STATUS_PENDING)

**Solution:**

- In AMO, the ```Version.models.update_status``` post_save signal calls ```Addon.model.update_status```.
- On Marketplace, we override ```update_status``` in Webapp and call it manually in developer views.
- Having Version call update_status on Addon/Webapp is an AMO behavior
- this patch checks when ```Webapp.update_status``` is being called from Version and tries not to call ```Webapp.update(status=...)```.