angular-ui/bootstrap — pull request #1635 by Foxandxss (2014-01-21 16:39:51+00:00)
Title: style(all): Remove all unused variables and parameters

From @Gamemaniak PR and @belkos idea, I open this.

I am not sure if I like the changes to be honest.

There was a lot of stuff to change but I spotted some stuff:

There are a lot of stuff that should be removed. A lot of unused injects, and some variables created in a `beforEach` that are not used.

Then, there are complaints about `link` functions parameters that are not used. Not sure what to think about this.

The docs are easily fix overriding the rule.

Then, in the tests, there was a lot of dirt, but maybe and I say maybe some of those dirt are good for readability.

Also, we have the hacky reflow in `collapse` and `carousel` which I don't see a happy way to jump that (removing the reflow makes the tests pass, that means that the reflow is not needed or that our tests are not that good, and I vote for the later).

For me is :-1: (Is this my PR right? :P). I would vote to clean what is really dirty (a lot of unused stuff) but maybe leave the link function params and things like that. The downside is that we are not enforcing anything then.

PD: I don't know why a commit for another PR I made is here too, my git-fu sucks, but well, out of curiosity, it helps with the cleanup also.