tgstation/-tg-station — pull request #2466 by Incoming5643 (2014-01-20 23:30:30+00:00)
Title: Fixes an oversight in slime reproduction

Funfact: before my refactor in #2354 slimes ran different code to reproduce depending on if life() did it automatically or if the reproduce() verb was used. Practically speaking this meant that player slimes and CPU slimes used different code. My pull fixed that, but what I didn't notice is that these two pieces of code weren't exactly identical:

When life did it the new baby slimes had the default nutrition (700)
When reproduce did it the slimes had 90% of the nutrition of the parent each.

Since a parent could store 1200 nutriton every child would usually gain ~1080 nutrition, even though naturally they could only store 1000 by themselves. As a result of this player split CPU baby slimes were never hungry and would evolve as soon as their "tick this up one if the slime is well fed" counter went to 10. My pull gave the player slime split behavior to the pure CPU slimes, meaning that if xenobio didn't act quickly to kill newborn slimes they'd have to deal with adults.

This pull emulates the old "functionality". Baby slimes spawned from CPU slimes will have default nutrition and have to be fed a monkey to evolve, player slimes will have children that may go adult by themselves if the player was thrifty about nutrition usage.