rapid7/metasploit-framework — pull request #2896 by wchen-r7 (2014-01-19 23:31:06+00:00)
Title: Update check in auxiliary

These check methods are updated mainly because either they wren't real checks (as in a check method not returning a checkcode because we didn't support it in the past), or incorrectly flagged based on the new guidelines in #2894.

Please note: PR #2894 should be landed first before this one.

## Verification steps for vmware_http_login:

The vmware_http_login module can be verified this way:

- [ ] Run a fake web server: ```ruby -run -e httpd . -p 8181```
- [ ] Without the patch, run msfconsole and do: ```auxiliary/scanner/vmware/vmware_http_login```
- [ ] ```set rhosts [IP]```
- [ ] ```set ssl false```
- [ ] ```check```
- [ ] Confirm you see: "Check failed: The state could not be determined", because there is no CheckCode thrown.

Now, with the patch:

- [ ] Repeat the steps above, but this time you should see: "This exploit does not support check"

## Verification steps for vbulletin_vote_sqli

- [ ] If you have the vulnerable setup, try run against it. If not, please rely on your mad code review skills. That's just what happens if you don't have a vuln box to test, and no test cases to try.

## Verification steps for other modules:

- [ ] Pease just rely on your mad code review skills.