kicks4kittens/metasploit-framework — pull request #1 by jvazquez-r7 (2014-01-17 23:48:47+00:00)
Title: Review IBM Lotus Sametime modules

Hi @kicks4kittens,

This pull request tries to clean https://github.com/rapid7/metasploit-framework/pull/2801. There are a lot of changes, and several of them are important, so please, check carefully, ask and discuss if there are any doubts on your side and finally, please test which all the modules are working after changes once you feel comfortable with them!

On my side just pointing two things:

* Please check if the SSL options are okey as are by default.
* I don't understand the synchronization problem on extend_queue on ibm_sametime_users. Please feel free to clarify the problem if there is indeed a race condition problem on extend_queue. If there is probably should be solved with a Mutex. I don't see the race condition problem by reading the code but didn't any test, so I could be forgetting something easily!

On our side we would need pcap / burp (XML!) captures for verification of modules working in order to land.