simonwidjaja/EdgeCommons — pull request #25 by matt-e-king (2014-01-17 08:58:08+00:00)
Title: updated soundjs to 0.5.2 http://code.createjs.com/soundjs-0.5.2.min.js t...

Hello! This is my first Pull Request so hopefully I am doing it right. Ultimately, I love EdgeCommons! Thanks for contributing this to the community. Not only am I using the library for Edge animations - but after doing some thorough testing, it appears the Sound library (SoundJS) somehow bypasses the limitations setup by iOS and Android for "simultaneous media" running at the same time. Normally you can't run two HML5 media elements at the same time - but its working with your library!

Anyways, I found during my development that things would break in the newer versions of Firefox:
![firefoxerror](https://f.cloud.github.com/assets/3094245/1938843/8e6026aa-7f54-11e3-99ea-d31fb140e94e.png)

(I think versions 25+). I found this article http://forums.adobe.com/message/5951142 and it turns out SoundJS updated their library in order to work in Firefox. So I forked your repo - copied and pasted the new version of SoundJS (http://code.createjs.com/soundjs-0.5.2.min.js) into your modules/Sound/Sound.js and it worked like a charm!! No more errors in Firefox and the animation loaded up just fine.

However with that in mind, for some reason when I recompiled EdgeCommons using Grunt, the minified version of EdgeCommons.js was throwing errors preventing the rest of the scripts to run
![edgeminifiederror](https://f.cloud.github.com/assets/3094245/1938829/40bcbba2-7f54-11e3-8271-ee03a8ae134e.png)

At first I thought this was because of the new SoundJS library but it wasn't. Here were my steps on how I tested...

1. I cloned your repo to my computer and I immediately copied *sprint/an/1.1.1/js/min/EdgeCommons.js* to my application and everything worked fine.
2. **Without making any modifications to the cloned EdgeCommons repo from Step 1** I ran your grunt command to recompile and create new minified files.
3. I then re-copied *sprint/an/1.1.1/js/min/EdgeCommons.js* which was **generated from Step 2**, to my application and it threw errors in the console (see image above)

Either way - this pull request is only for the Sound.js file with the new version of SoundJS - not sure why I couldn't get the minified versions to work, but the files in the *sprint/an/1.1.1/js/max* directory worked just fine and cleared the errors in Firefox. Please feel free to email me at mking@crownchimp.com if any of this was any help or raised any concerns.