astropy/astropy — pull request #1971 by mdboom (2014-01-16 16:21:51+00:00)
Title: Fix compilation on Python 3.4

Upstream Python 3.4 now includes `-Werror=declaration-after-statement` in their compiler flags. This causes the compilation of cfitsio's `swapproc.c` to fail. (It's kind of obnoxious that distutils forces the compiler flags for Python itself on all of the extensions that get built -- it makes sense for some, but not all of them, but in any case distutils has done that for *ages*).

```
cextern/cfitsio/swapproc.c: In function ‘ffswap2’:
cextern/cfitsio/swapproc.c:83:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
long ii;
^
cc1: some warnings being treated as errors
error: command '/usr/lib64/ccache/gcc' failed with exit status 1
```

@embray: How do you normally handle changes to cfitsio like this? With wcslib, I maintain a set of patches so that we can upgrade the library and reapply these fixes at any time (and in the meantime, I report upstream).