silverstripe/silverstripe-framework — pull request #2760 by madmatt (2014-01-08 02:13:28+00:00)
Title: BUGFIX: Fix SecurityAdmin checkboxes not being properly unchecked

This fixes a bug where while editing a group in SecurityAdmin, if you went to the Permissions tab, and selected the 'Full administrative rights' checkbox, then if you unchecked the same checkbox, all the other checkboxes were still disabled and checked, meaning you couldn't change them. This led to inconsistent UX - they were checked, but didn't submit so the permissions didn't change.

This fixes both the 'Full administrative rights' and 'Access to all CMS sections' checkboxes. The CMS will remember which checkboxes were checked prior to turning them all on, and restore those choices when you uncheck one of those two checkboxes.

This works in latest Chrome, latest Firefox for Mac, and IE9. I haven't extensively tested other browsers.