mozilla/kitsune — pull request #1787 by mythmon (2014-01-07 19:14:13+00:00)
Title: Lint

1. I removed all the old disused linting stuff I found.
2. I add a shiny new `scripts/lint.sh` that uses pep8 and pyflakes (via flake8).
3. I hacked on the kitsune source code until `lint.sh` stopped yelling.
4. I filed this pull request.

The linter complained mostly about silly things. Indentation being too much or too little. One of the challenging parts was the raw sql we have. I tried to keep the code mostly readable (as readable as raw sql can be, that is) while still making the linter happy.

This linter doesn't care about import order yet. I haven't made this fail Travis builds if style is bad yet. I wanted to merge this soon before the code changed too much to avoid merge errors, since I touched a lot of code.

I do not claim that this is good style. I claim that this pleases the linter, and passes the tests.

r?