jfryman/puppet-nginx — pull request #223 by 3flex (2014-01-03 18:08:44+00:00)
Title: Add validation for $priority

Valid range changed to 401-599:

vhost SSL header has priority 700. If $priority is set to 400 (which resolves to 400+300=700 for SSL locations), then it would conflict with the priority of the header. It must be 401 or higher to avoid this.

Top end of range is limited to 599 to reflect documentation however it could be increased to 698 and still provide expected behavior.

Current default priorities:
* 001 HTTP header
* 500 nginx::resource::location default (included when `$ssl_only != true`, which is default)
* 699 HTTP footer
* 700 SSL header
* 800 nginx::resource::location default (included when `$ssl == true`). Is `$priority + 300`.
* 999 SSL footer

Non-conflicting HTTP location fragment priorities: 002-698. `$priority` valid range is the same.
Non-conflicting SSL location fragment priorities: 701-998. Means `$priority` valid range is 401-698.

Documentation says valid range is 400-499 and 501-599. This is correct for HTTP is almost correct for SSL range (should be 401-499).