onehealth/marionette.formview — pull request #6 by pivotal-pan (2013-12-31 01:18:13+00:00)
Title: Removing trim from getters. Validation should not manipulate data.

A few notes on this pull request:
- We couldn't get lint to run without changing package dependencies and the Gruntfile. After that, default linting blew up everywhere, so we skipped it as it seems it may not have run in the past.
- Running the build task seems to have scooped up a part of the previous commit's changes. Not sure what your build strategy is.
- We are mainly suggesting this fix as we use FormView for a password reset mechanic; our QA found leading and trailing spaces were bombing in the UI and saw this bug. Seeing that whitespace trimming is manipulating user data, we figured the correct course of action was to take the trim out. There were no specific test cases for the whitespace but we added a few leading whitespaces to the existing test cases, saw them fail, fixed the code, etc.

If there was some rationale for the trim that we overlooked let us know and maybe we can adopt a different strategy.

Thanks, Sam & Rob.