basho/riak_core — pull request #491 by jrwest (2013-12-25 22:12:33+00:00)
Title: remove legacy forwarding code that snuck in as part of 632af2b3ce9

Handling of forwarding code was changed in #301. Changes made as part
of the commit mentioned above were most likely made prior to that PRs merge.

Remove the forwarding code as it is redundant (the decision to forward
is handled further up the call stack). It caused vnode when resizing to
crash, since the check was not as comprehensive as its
caller. The vnode would crash when attempting to forward to a
partition identified by `{Index, [{Index, Owner}]}` which is invalid.

See http://giddyup.basho.com/#/projects/riak_ee/scorecards/66/66-712-verify_dynamic_ring-centos-6-64-bitcask/30889/artifacts/435114 for example failure. `verify_dynamic_ring` in `riak_test` should now pass with this change and `sync_command_test` in `riak_core` should continue to pass.