lonelyplanet/ui-test — pull request #23 by davehightower (2013-12-21 03:53:27+00:00)
Title: Commits for UI Test

Well, hello there!

I based the majority of my decisions for this Lonely Planet test page on the JS that runs the lightboxes. I wasn't satisfied with the way they were working (or not working), so I implemented some different JS for these. I'm pleased with the results—I used Fancybox for this. Otherwise, my changes had to do with restructuring, cleaning up, and commenting on the code, and implementing some new styles on the page.

I converted the style.sass file to style.scss, because I like working with that syntax better. I think the major addition I would have liked to put into this would have been media queries for flexible navigation and scaling. I played with some preliminary ideas for that, but wanted to get this turned into you...with some more time, I could definitely do that, though!

Significant additions:
--> HAML: Moved JS calls to the bottom of the page, changed the .image-container structure in index.haml to accommodate Fancybox, added webfont calls - Oswald and Open Sans (a pretty good combo, I think)

--> CoffeeScript: Removed the lightbox code from read-more.coffee

--> SASS: Converted to SCSS and added new styles

Thanks for considering my application!

Here's to a great holiday!

~Dave Hightower
dave@dhightower.com
http://dhightower.com