rails/rails — pull request #13414 by britto (2013-12-19 23:42:55+00:00)
Title: Improve ERB dependency detection

Following the discussion started on #13116, I thought it might be worth giving a shot at some of the issues we have identified.

The current implementation can't handle some special cases of oddly-formatted Ruby. Now we are able to detect them:

* Multi-line arguments on the `render` call
* Strings containing quotes, e.g. `"something's wrong"`
* Multiple kinds of identifiers - instance variables, class variables and globals
* Method chains as arguments for the `render` call

Also, this fix reduces the rate of "false positives" which showed up when we had calls/access to identifiers containing `render`, like `surrender` and `rendering`.

Related: #13074.