thoughtbot/shoulda-matchers — pull request #405 by mcmire (2013-12-19 03:00:41+00:00)
Title: Make `order` option Rails 4.0.1-compatible

This is a fix for #388.

From the commit:

> The way that we figure out whether the value which is passed to `order`
is the same as the `order` that the association was defined with is by
creating an ActiveRecord::Relation object from the given `order` and
comparing it with the Relation stored under the association.
Specifically, every time you call `order` on a Relation, it appends the
value you've given to an internal `order_values` array, so we actually
access this array and compare the two between the two Relation objects.

> Currently we assume that this `order_values` array is an array of
strings, so it's very easy to compare. That was valid pre-Rails 4.0.1,
but it looks like as per [these][1] [commits][2], it's now possible for
`order_values` to be an array of Arel nodes. So, to make a proper
comparison, we have to convert any Arel nodes to strings by calling
#to_sql on them.

[1]: rails/rails@d345ed4
[2]: rails/rails@f83c9b1