elixir-lang/ecto — pull request #139 by Enders (2013-12-16 13:42:53+00:00)
Title: Quote all table and field names in Postgre Adapter generated SQL

As per #118, I have updated the postgre adapter to quote all table and field names in the generated SQL, excluding the generated names (for instance: SELECT * FROM "table" as t0 WHERE t0."id" = 3).

All tests are passing after updating them with the new expected output, it looks reasonnable. I haven't tested this in depth in an actual Ecto app that would use all those queries, I am not sure what is the usual protocol for those kind of modifications? (I didn't see any actual system tests that would connect to a test postgre DB, did I miss them?)

Also, I haven't added in the 'failing test' from #118 because I don't think it's useful for it to be in the testing suite (but it's helpful to showcase why quoting is important!).

Thanks for the feedback!