branan/puppet-module-minecraft — pull request #7 by andschwa (2013-12-15 04:52:45+00:00)
Title: Bukkit, templates, and more!

Hi Branan,

This is a pretty big pull request that I've been working on and off with for a while. I've tested it on my own VM, but please do test it more extensively before merging. There are a few major things I've added:

For starters, Bukkit can now be used in addition to Minecraft, and particular versions of either can be specified and auto-downloaded.

All settings (from server.properties to player management) have been parameterized and are configurable through templates. This is not an over-writing-with-defaults template like in another pull request, but instead creates the files using values specified as parameters to the class. This cleans up the code base, I believe eliminates the stdlib dependency by removing the use of file_line, and plain works better with Puppet. It also removes the use of resources, instead allowing all settings to be specified with the initial declaration of the Minecraft class.

I've updated the README to suit, and gathered all parameters into minecraft::parameters. I've taken the liberty of updating the name of the module to the more generic "puppet-minecraft", and added the Bukkit capabilities to the description. I've also bumped the version number to 1.1.0, and if you don't mind, added myself as a co-author. (If you do mind, feel free to remove it and just mention me as a contributor).

I hope you like this, it sure is working well for me. If you have any ideas for further improvement, I'm all ears!

Cheers,

Andrew Schwartzmeyer