elkarte/Elkarte — pull request #1146 by Spuds (2013-12-11 04:16:33+00:00)
Title: Updates to messageTopicDetails and basicMessageInfo

Please look this over carefully, this change started with a todo that I was looking at and then I could not figure a few things out.

First up was messageTopicDetails which this PR removes and replaces by adding some updates to basicMessageInfo function.

messageTopicDetails: https://github.com/Spuds/Elkarte/commit/6cd59ba342cae2d36324152cb2fdcf9ab2ff806b#diff-f90320aaabfe2eb736cc2698695aa6d9L1365 My concerns were a) it does not check permissions, query_see_board stuff, but looks like it was used in Emailuser to see if the member had access to the message? 2) The topic id used in the join is not set from the topic id found in the message table .. this means you could pass it a message id from topic X and then a topic id from topic Z and it will return results like topic_first_message but for that topic, not necessary the topic of the message id that is also passed. Not sure if that was intended but seemed odd to me.

The old function was used in 3 places, so this converts them over to the new function and removes the old one, but want some other eyes on this one.