hep-gc/shoal — pull request #46 by robprior (2013-12-09 23:19:12+00:00)
Title: Config file refactor

The way the config.py files were done before were prone to shadowing
errors; every variable was declared globally to make it accessible to the
shoal branch main code and to set default values. The default was overwritten in
the setup function which, had global declarations for all variable at
the start. Forgetting to add a global deceleration caused shadowing; both a
local and a global variable were created with the same name. The default value
was never overwritten in setup because the config file value was assigned
to the local variable. These errors are relatively hard to find as they are silent;
no error message or warning will be generated. To prevent this, the setup
function was removed as its parameter was not used, and the body of the function
is basically the entirety of the file (so being in a function did not really
improve organization).

Also minor updates to the default config files: removed some outdated
comments, changed default AMQP server to be shoal.heprc.uvic.ca and the
default port to be 5672 (no SSL port).