wimg/PHPCompatibility — pull request #22 by sumpygump (2013-12-06 07:06:47+00:00)
Title: Update tests

I added more tests for new sniffs that were created recently and also fixed a few things I found during testing.

1. **LongArraySniff**: It was defaulting to the wrong version for comparison, should be PHP 5.3 since that is the version when the variables in question were deprecated.
2. **NewIniDirectivesSniff**: It was not handling when using ini directives with double quotes, i.e. `ini_set("allow_url_include", 1);`
3. **NewIniDirectivesSniff**: Logic for comparing PHP versions was reversed. It was checking whether versions were forward from the version in question instead of backwards.
4. **NewKeywordsSniff**: Updated the order that items appear in the array of tokens to check so they are consistently sorted by PHP versions.
5. I updated the sniff tests to work with the new master branch of PHP_CodeSniffer, that includes the `--config-set testVersion x.x` way of specifying the PHP version for which to sniff.

Results of running tests now (using master branch of PHP_CodeSniffer installed via composer):
```
$ php --version
PHP 5.4.9-4ubuntu2.3 (cli) (built: Sep 4 2013 19:32:25)
Copyright (c) 1997-2012 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2012 Zend Technologies
with Xdebug v2.2.2, Copyright (c) 2002-2013, by Derick Rethans

$ phpcs --version
PHP_CodeSniffer version 1.5.0 (stable) by Squiz (http://www.squiz.net)

$ phpunit
PHPUnit 3.7.28 by Sebastian Bergmann.

............................................................... 63 / 237 ( 26%)
............................................................... 126 / 237 ( 53%)
............................................................... 189 / 237 ( 79%)
................................................

Time: 48.69 seconds, Memory: 30.25Mb

OK (237 tests, 942 assertions)
```